Skip to content

fix(audioreactive): skip i2s_set_clk() for PDM mode on IDF 5.x #5807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aenertia wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(audioreactive): skip i2s_set_clk() for PDM mode on IDF 5.x #5807

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1021759
fix(audioreactive): skip i2s_set_clk() for PDM mode on IDF 5.x
aenertia Aug 18, 2026
da6a62c
style: restore upstream comments, drop verbose block per reviewer fee…
aenertia Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions usermods/audioreactive/audio_source.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,14 @@
#ifdef I2S_USE_RIGHT_CHANNEL
#define I2S_MIC_CHANNEL I2S_CHANNEL_FMT_ONLY_RIGHT
#define I2S_MIC_CHANNEL_TEXT "right channel only."
#define I2S_PDM_MIC_CHANNEL I2S_CHANNEL_FMT_ALL_RIGHT
Comment thread
softhack007 marked this conversation as resolved.
#define I2S_PDM_MIC_CHANNEL_TEXT "right channel (ALL_RIGHT for PDM compat)."
#else
#define I2S_MIC_CHANNEL I2S_CHANNEL_FMT_ONLY_LEFT
#define I2S_MIC_CHANNEL_TEXT "left channel only."
#define I2S_PDM_MIC_CHANNEL I2S_CHANNEL_FMT_ALL_LEFT
#define I2S_PDM_MIC_CHANNEL_TEXT "left channel (ALL_LEFT for PDM compat)."
#endif
#define I2S_PDM_MIC_CHANNEL I2S_MIC_CHANNEL
#define I2S_PDM_MIC_CHANNEL_TEXT I2S_MIC_CHANNEL_TEXT

#endif

Expand Down Expand Up @@ -294,11 +296,13 @@ class I2SSource : public AudioSource {
}

#if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(4, 2, 0)
err = i2s_set_clk(I2S_NUM_0, _sampleRate, I2S_SAMPLE_RESOLUTION, I2S_CHANNEL_MONO); // set bit clocks. Also takes care of MCLK routing if needed.
Comment thread
aenertia marked this conversation as resolved.
if (err != ESP_OK) {
DEBUGSR_PRINTF("AR: Failed to configure i2s clocks: %d\n", err);
i2s_driver_uninstall(I2S_NUM_0); // uninstall already-installed driver
Comment thread
softhack007 marked this conversation as resolved.
return;
if (!(_config.mode & I2S_MODE_PDM)) {
err = i2s_set_clk(I2S_NUM_0, _sampleRate, I2S_SAMPLE_RESOLUTION, I2S_CHANNEL_MONO); // set bit clocks. Also takes care of MCLK routing if needed.
if (err != ESP_OK) {
DEBUGSR_PRINTF("AR: Failed to configure i2s clocks: %d\n", err);
i2s_driver_uninstall(I2S_NUM_0); // uninstall already-installed driver
return;
}
}
#endif
_initialized = true;
Expand Down
Loading