Repository navigation
net_io: bind up to 64 addresses per listening port - #200
Closed
enricolorenzoni59 wants to merge 1 commit into
Closed
enricolorenzoni59 wants to merge 1 commit into
enricolorenzoni59 wants to merge 1 commit into
Conversation
newfds holds the descriptors anetTcpServer() returns for one bind argument. The count passed to it is the array capacity now, so the 16 entry array silently ignored every address a hostname resolved to beyond the first 16. Raise it to 64: getaddrinfo() rarely returns more, 64 ints are 256 bytes of stack, and --net-bind-address then uses every address of a multi-address name. With an interposer returning 40 addresses for one name, readsb listened on 16 sockets before this change and on 40 after it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you really want 64 addresses... :)