Repository navigation
Make the Beginner capstone cards match a real run at T1, T3, T5 and T6 (350) - #235
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The Beginner capstone's cards now match what a real Claude Code v2.1.309 session did in the live Beginner run:
npm run linkcheck -- <that folder>is on the card's do line, not behind a hint. The commit-CLAUDE.mdadvice was abottom:line (the exact command, shown only on request); it is now a note on the git-clean beat, with the reason (the fix commit may change only the files the plan names), and the exact command holds the two git commands.../capstone/beginner-bug.md, the card and page say the read may need no prompt: Claude can read it withcat, which Claude Code runs without a permission prompt unlesspermissions.blockReadsOutsideWorkingDirectoriesis on (Read-only commands).<file>is saved" for a file beat. A git-clean beat that names paths (i-4 W2.env, i-capstonesamples/, i-8 Y3) keeps its card, since its step asks for no change there. A snapshot test covers both, and fails with the old behavior.Not changed: T5 names the file both in its Check line and in the "Found" evidence after it passes; the Check line says what the beat looks for, the evidence what it found.
Checklist
Claim table
Filled by a separate agent that tried to refute each changed claim:
catamong them, without a permission prompt (docs/beginner/capstone.md step 3 and course/steps/b-capstone.md T3 note)ls,cat,echo,pwd,head,tail, ...". Plan mode (where this step runs) agrees: permission-modes.md says commands "outside the built-in read-only set prompt for approval", so commands inside it don't. One caveat the sentence leaves out: "In auto mode, these commands can also wait for the classifier's review". The step's "may need no prompt" wording covers that.permissions.blockReadsOutsideWorkingDirectoriesis on (acatof the report outside the working directory can then prompt)permissions.blockReadsOutsideWorkingDirectorieschanges for paths outside your working directories", and permission-modes.md says "Reads outside the working directories whilepermissions.blockReadsOutsideWorkingDirectoriesis on: recognized file-reading Bash commands prompt even in auto mode andbypassPermissionsmode ... Requires Claude Code v2.1.257 or later." This check did not compare that minimum version with the guide's frozenstablebaseline.The v2.1.257 minimum in the second row is older than the guide's
stablebaseline, v2.1.309.Dry-run
Live run rel350-cap, from this branch (80d93da) seeded through b-5, with real Claude Code v2.1.309 at start and end, a clean configuration, macOS, driven only by what the app shows (logs
~/.learn-runs/logs/rel350-cap/). The final Check printed "7 of 7 passed" and the app showed "CAPSTONE COMPLETE".All relative links resolve.with exit 0. The git-clean beat reads "Passes: nothing is left uncommitted", with the commit-CLAUDE.mdnote. The live run's missing bottom line (F4) came from beat 1: the seeded copy already passes it, so it shows "Already done, so this step counts." and no exact command; the note on beat 2 now carries the commands.cat ../capstone/beginner-bug.md; echo ---; ls -R src test; cat package.jsonand went straight to the plan. The new note covers exactly this.src/cli.jsand reported "All 18 tests pass" without pausing; the note is conditional. The LSP plugin recommendation dialog appeared and No, not now matched the card;plugins/stayed unchanged.