Repository navigation
TOWER-25660: Enforce Eagle color lint with targeted exceptions - #1403
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira ticket
问题描述
Eagle 的硬编码颜色规则原先以 warning 报告。未加放行注释的硬编码应阻断 CI。没有完全等值 token 的历史颜色和配方需要保留原值,并在使用处说明原因。
改动
check:theme覆盖的生成文件路径。自测结果
test:colors、lint:colors和lint:colors:ts均通过。验证了同一个#00122e未加注释时会报错,加上对应规则的行内放行指令后可通过,相邻未放行的声明仍会报错。合入前可手动运行yarn workspace @cloudtower/eagle test:styles比对浏览器 computed style 快照。