Skip to content

TOWER-25363 fix(Banner): allow overriding the root id - #1401

Draft
liangyuyuyu wants to merge 1 commit into
mainfrom
TOWER-25363
Draft

liangyuyuyu wants to merge 1 commit into
mainfrom
TOWER-25363

Conversation

@liangyuyuyu

@liangyuyuyu liangyuyuyu commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

问题描述

Banner 组件默认设置了 id 为 global-banner ,如果同一个页面展示了多个 global-banner ,且有一些功能依赖 global-banner 时会出现问题。

解决方案

id 可以通过 Banner prop 传入,同时为了兼容旧的使用方式,id prop 默认值为 global-banner ,不期望设置 id 时可以把 id 设置为空字符串。

自测结果

image

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Nov 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cloudtower-ui-kit Ready Ready Preview Nov 18, 2026 3:52pm UTC

@liangyuyuyu

Copy link
Copy Markdown
Collaborator Author

@chenenpei @netweng PTAL

@netweng

netweng commented Nov 19, 2026

Copy link
Copy Markdown
Member

一个组件有默认 id 这个行为就很奇怪。。。。id 应该是唯一性,这个组件会在很多地方用,这样相当于 getelementbyid 会影响到很多地方。

@netweng

netweng commented Nov 19, 2026

Copy link
Copy Markdown
Member

哦,这个组件在 4.11 对齐了,建议是不要带默认 global banner 的 id 了。

#1378

你的优化可以放到 4.11 一并处理吗,因为 4.11 也调整了 tower global banner 的处理。

@liangyuyuyu

Copy link
Copy Markdown
Collaborator Author

你的优化可以放到 4.11 一并处理吗,因为 4.11 也调整了 tower global banner 的处理。

这是那个 ticket 呀?我这边是 TOWER-25363 ,那我沟通一下移到 4.11.0

@liangyuyuyu
liangyuyuyu marked this pull request as draft November 19, 2026 03:16

This branch was successfully deployed

1 active deployment
Preview — 71763c58 Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants