test: close mutation coverage gaps - #12
Merged
Merged
Conversation
Asserts the hops argument in the notification middleware tests, covers the addHop and prepareMessages continue branches, and normalizes sendNow hops so the null-hops mutant is no longer equivalent.
tyrsson
added
the
ims-migration
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the escaped-mutant gaps surfaced by the mutation test (Infection) — brings Covered Code MSI to 100%.
hopsargument in theNotificationMiddlewaretests.addHopandprepareMessagescontinuebranches.sendNowhops ($hops ??= 1) so the null-hops mutant is no longer behaviorally equivalent.Verified:
composer test(69 tests, 139 assertions),composer mutation-test(0 escaped, 100% MSI), mago format/lint/analyze/guard all clean.