feat: add command-result notification middleware - #11
Merged
Merged
Conversation
Centralizes SystemMessage dispatch. The middleware reads the message-bus CommandResult request attribute and pushes a success/warning flash notification when the command implements NotificationCapableInterface. Refs webinertia/webware-acl#22
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
NotificationCapableInterface(success/failure message property hooks) and a centralizedNotificationMiddlewarethat reads the message-busCommandResultrequest attribute and pushes a success/warning flash notification when the command implements the interface. This moves per-dispatch SystemMessage handling out of theProcess*middleware into this package.Also bumps
webware/webware-toolsto the mago 1.47.3 pin and fixes a package-name typo in one copyright header.Refs webinertia/webware-acl#22