Initial webware-htmx import from IMS - #1
Merged
Merged
Conversation
Import the Htmx module from inventory-management-system and align it with the webware-tools pipeline. - Htmx\ -> Webware\Htmx namespace - composer (platform 8.4.99, test scripts, php-standard-library/type) - phpunit 13.1 + 68 tests (body/layout renderer, config override) - mago tooling with 19 deferred findings baselined - infection/codecov/renovate/phpbench configs + CI workflow wrapper - README badges and copilot instructions
tyrsson
added
tooling-alignment
github-project-automation
Bot
moved this to Todo
in inventory-management-system-tracking
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
The layout/body selection in LaminasRendererFactory (first/last over a combined candidate list) is intentional: the action template renders into the body, which renders into the layout. Revert the earlier split into separate candidate lists and restore the renderer's original type declarations. Update ConfigOverrideTest to configure a layout (as a real Mezzio app always does) and assert the full action -> body -> layout output.
Replace the on-the-fly temp template files with a committed test/integration/templates directory (page/body/layout/userland namespaced layout) so the integration tests prove real path resolution and loading, not templates constructed inside the test.
github-project-automation
Bot
moved this from Todo
to Done
in inventory-management-system-tracking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imports the
Htmxmodule frominventory-management-systemand aligns it with the webware-tools pipeline.Highlights
Htmx\→Webware\Htmx\php-standard-library/typeServerRequestFilterheader case-insensitivity, andLaminasRendererFactorylayout/body conflation (double-wrap)Depends on: none (leaf package — mezzio + laminas-view only).