Drop Button Implementation in widgets by ajitkumar0828-spec · Pull Request #735 · webex/widgets

ajitkumar0828-spec · 2026-08-18T09:54:35Z

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

< DESCRIBE THE CONTEXT OF THE ISSUE >

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

The testing is done with the amplify link
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

I have not skipped any automated checks
All existing and new tests passed
I have updated the testing document
I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13b15ed84f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-08-18T09:59:38Z

+    if (pendingRequest && (pendingRequest.taskId !== participantDropTaskId || pendingRequest.task !== currentTask)) {
+      pendingParticipantDropRef.current = null;
    }
-  }, [currentTask, controls]);
+
+    setPendingParticipantDropId(null);
+    setParticipantDropAnnouncement(null);
+  }, [currentTask, participantDropTaskId]);


Preserve pending drops across same-interaction refreshes

Reset the pending request only when the interaction actually changes, not whenever currentTask gets a new object identity. StoreWrapper.refreshTaskList() calls setCurrentTask(), which clones the task even when its interaction ID is unchanged, and participant-left/UI-control events invoke that refresh during the event-correlated SDK request. This effect therefore clears the global lock and announcement before the promise continuation runs, allowing a second Drop and suppressing the normal success or failure feedback for the first request.

Useful? React with 👍 / 👎.

aws-amplify-us-east-2 · 2026-08-18T10:00:59Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-735.d1b38q61t1z947.amplifyapp.com

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f10ce0e50

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-08-18T10:50:53Z

+
+  // Prefer the observable task data when it already contains the current leg;
+  // fall back to the state-machine snapshot during the brief hydration gap.
+  const taskDataCandidates = [task.data, snapshotTaskData].filter((taskData): taskData is RosterTaskData =>


Prefer the newest consult snapshot over stale task data

When a completed consult leg remains in task.data and a subsequent EP-DN consult is present only in state.context.taskData, this ordering returns the old leg immediately, so the newer snapshot is never examined. This is a supported transition in this repository—other consult logic explicitly accounts for retained old media and fresher initiator snapshots—and can make the Drop roster show the prior destination or omit the current ringing/answering participant until hydration catches up. Compare leg recency/current media IDs across both candidates rather than accepting the first consult entry.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 053e6f46f7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-08-19T06:57:25Z

+  const consultIsActive =
+    hasVisibleControls(task?.uiControls?.consult) || ['consult', 'consulting'].includes(interactionState);


Recognize consults exposed on the main controls

When a nested or EP-DN consult keeps interaction.state at conference and the SDK exposes only uiControls.main.endConsult—a supported shape already handled in task/src/helper.ts and its tests—this predicate incorrectly treats the consult as inactive because it inspects only uiControls.consult. Consequently getCurrentConsultMediaEntry omits the ringing or answering destination, while the identical predicate in hasActiveNonHeldConsult leaves Drop enabled for established participants during the active non-held consult; include the main-leg end-consult signal in both derivations.

Useful? React with 👍 / 👎.

Kesari3008

Only few files I have reviewed. Have added comments for those. Please address these comments before merge. Approving the PR, keeping the deadline in mind. But PR needs to be revisited for thorough review

Kesari3008 · 2026-08-21T07:00:21Z

      "path": "packages/contact-center/store",
      "spec": "packages/contact-center/store/ai-docs/store-spec.md",
-      "responsibility": "MobX singleton holding global CC state; proxies SDK events; sole SDK access point.",
+      "responsibility": "MobX singleton holding global CC state; proxies SDK events; sole SDK access point; owns pure conference Drop roster derivation.",


These changes may not be needed. This feature is just an addition among serveral other features and explicitly adding it in manifest is not required

Kesari3008 · 2026-08-21T07:19:13Z

+    }
+  }, [customerDropTarget, latestCustomerDropTarget]);
+
+  const handleParticipantDrop = (target: ConferenceParticipantDropTarget, trigger: HTMLElement) => {


These methods belong in helper file, not in the presentational component. Any method that is performing an action or business logic should be in helper files and passed down here via props to be invoked here.

Kesari3008 · 2026-08-21T07:27:53Z

+      </h4>
+      <ul className="participant-roster-list">
+        {targets.map((target) => {
+          const isSelectedPending = pendingParticipantDropId === target.dropTargetId;


Avoid this where we have constants defined inside UI logic. This ideally should be outside

Kesari3008 · 2026-08-21T07:38:29Z

+const PARTICIPANT_DROP_SUCCESS_MESSAGE = 'Participant removed from the conference.';
+const PARTICIPANT_DROP_FAILURE_MESSAGE = 'Unable to drop participant from the call. Try again.';
+
+type PendingParticipantDropRequest = {


This should be in types files

Kesari3008 · 2026-08-21T07:39:29Z

  // pause/resume, etc.) exactly as production does.
-  store.handleIncomingTask(task);
-  store.setCurrentTask(task);
+  store.handleIncomingTask(task as unknown as Parameters<typeof store.handleIncomingTask>[0]);


This change is not needed

Kesari3008 · 2026-08-21T11:34:49Z

    });
  };

+  private scheduleTaskListRefresh = (): void => {


Is this change needed for drop feature ?

Implement contact center widget enhancements

13b15ed

ajitkumar0828-spec requested a review from a team as a code owner August 18, 2026 09:54

chatgpt-codex-connector Bot reviewed Aug 18, 2026

View reviewed changes

Keep participant trigger and chevron on one line

8f10ce0

chatgpt-codex-connector Bot reviewed Aug 18, 2026

View reviewed changes

Refine consult media selection using state snapshots

053e6f4

chatgpt-codex-connector Bot reviewed Aug 19, 2026

View reviewed changes

Kesari3008 approved these changes Aug 21, 2026

View reviewed changes

		const consultIsActive =
		hasVisibleControls(task?.uiControls?.consult) \|\| ['consult', 'consulting'].includes(interactionState);

Uh oh!

Conversation

ajitkumar0828-spec commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

aws-amplify-us-east-2 Bot commented Aug 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

Kesari3008 left a comment

Choose a reason for hiding this comment

Uh oh!

Kesari3008 Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Kesari3008 Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Kesari3008 Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Kesari3008 Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Kesari3008 Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Kesari3008 Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ajitkumar0828-spec commented Aug 18, 2026 •

edited

Loading