Participant drop functionality and tests by ajitkumar0828-spec · Pull Request #5174 · webex/webex-js-sdk

ajitkumar0828-spec · 2026-08-18T09:04:27Z

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

< DESCRIBE THE CONTEXT OF THE ISSUE >

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

I certified that

I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9fe344435c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-08-18T09:07:19Z

+            data: {
+              type: CC_EVENTS.PARTICIPANT_LEFT_CONFERENCE,
+              interactionId: p.interactionId,
+            },


Bind drop completion to the requested participant

When any other participant leaves the same conference while this request is pending, this bind also matches that ParticipantLeftConference event because it checks only the interaction ID. AqmReqs then resolves and clears the drop request even if the requested target remains or later produces a failure, so callers receive a false success. Include the requested participant ID in the success correlation bind, and likewise correlate the failure bind where supported.

AGENTS.md reference: packages/@webex/contact-center/AGENTS.md:L51-L51

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-08-18T09:07:19Z

+  const customerNumber = hasActiveCustomer ? getCustomerNumber(interaction) : '';
+  const customer = customerNumber
+    ? {
+        participantId: customerNumber,
+        displayName: customerNumber,


Send the customer's roster identifier to the drop API

When a conference includes a customer and another participant, the Drop customer action uses ANI/DNIS as participantId, although the SDK endpoint expects the backend participant identifier from the task roster. Clicking the button therefore targets the phone number rather than the customer's participant record and can reject or time out; retain the customer's resolved roster ID for participantId and use the number only as displayName.

Useful? React with 👍 / 👎.

aws-amplify-us-east-2 · 2026-08-18T09:15:18Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-5174.d3m3l2kee0btzx.amplifyapp.com

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2564fe942c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-08-19T08:47:28Z

+  const consultMedia = Object.values(task?.data?.interaction?.media || {}).find(
+    (media) => media?.mType?.toLowerCase() === 'consult'
+  );


Check the current consult leg before enabling Drop

When the interaction retains more than one consult-media entry, this selects the first entry even though getCurrentConsultMedia() immediately above resolves the configured or latest consult leg. If an older leg is held but the current leg is active and unheld, hasActiveNonHeldConsult() returns false and enables participant Drop during the active consult; the inverse ordering incorrectly disables it. Use the current consult-media selection here so the roster reflects the leg the agent is actually controlling.

Useful? React with 👍 / 👎.

Kesari3008

Except test files and .md files, reviewed the code

Kesari3008 · 2026-08-19T06:08:03Z

      "contracts": {
        "provides": [
-          "Published @webex/contact-center package; ContactCenter WebexPlugin; public SDK methods, events, types, Task, AddressBook, ApiAIAssistant, UserPreference, cc.userPreference, exported user-preference request/response types, and preview-campaign methods acceptPreviewContact/skipPreviewContact/removePreviewContact"
+          "Published @webex/contact-center package; ContactCenter WebexPlugin; public SDK methods, events, types, Task, AddressBook, ApiAIAssistant, UserPreference, cc.userPreference, exported user-preference request/response types, preview-campaign methods acceptPreviewContact/skipPreviewContact/removePreviewContact, and DropConferenceParticipantPayload/task.dropConferenceParticipant"


Why are we adding specifically about this feature in the manifest file. I dont consult, tranfer or conference flows explicitly mentioned here so why only this feature

Kesari3008 · 2026-08-19T06:55:48Z

+                  method: METHODS.CREATE_PROMISE,
+                });
+              }
              const eerr = new Err.Details(notifFail.errId, msg as any);


There is a typo here for this error variable, we can fix it. Also why do we need to add this condition ?

Kesari3008 · 2026-08-19T14:40:26Z

              actions: ['updateTaskData', 'clearConsultState', 'emitTaskConsultEnd'],
            },
          ],
+          [TaskEvent.PARTICIPANT_LEAVE]: [


This state transition is not following the definition of state machine. target and actions are the property it takes which is missing here. Why is a new event being introduced like this ?

Kesari3008 · 2026-08-19T14:43:34Z

+  public async dropConferenceParticipant(
+    payload: DropConferenceParticipantPayload
+  ): Promise<TaskResponse> {
+    const participantId = payload?.participantId;


payload is mandatory param in the method definition so why is ? present marking it optionally being present

Kesari3008 · 2026-08-19T14:52:19Z

+   * @returns Promise<TaskResponse>
+   */
+  public async dropConferenceParticipant(
+    payload: DropConferenceParticipantPayload


This payload seems to be be having just one property, why have created new type for it. We can directly say in the definition participantId: string and also if we are specifically defining it to be string why is the string check in the if block needed

Kesari3008 · 2026-08-19T15:14:30Z

+    },
+  ];
+
+  const survivingParticipantLeaveTransition = {


This optimization is unncessary

Kesari3008 · 2026-08-19T15:16:40Z

              actions: ['updateTaskData', 'clearConsultState', 'emitTaskConsultEnd'],
            },
          ],
+          [TaskEvent.PARTICIPANT_LEAVE]: [


Why would be any Agent in Connected state if they are in conference. Connected state is only for 1:1 call with customer. And when a participant leave happens, it can only happen in conference state. This transition may not be valid

Kesari3008 · 2026-08-19T15:17:35Z

            target: TaskState.CONNECTED,
            actions: ['updateTaskData'],
          },
+          [TaskEvent.PARTICIPANT_LEAVE]: [


Same comment here. We will have to evaluate if drop is something being attempted in HOLD_INITIATING state or RESUME_INITIATING state

Kesari3008 · 2026-08-19T15:21:24Z

  handleConferenceStarted: assign({consultInitiator: false}),

-  setConsultDestination: assign(({event}: TaskActionArgs) => {
+  setConsultDestination: assign(({context, event}: TaskActionArgs) => {


Why have we introduced this change ?

Kesari3008 · 2026-08-19T15:23:42Z

-    //    agent is absent from the updated participants, they have left.
-    const participants = taskData?.interaction?.participants;
-    if (participants && !(selfAgentId in participants)) {
+    const currentParticipant = taskData?.interaction?.participants?.[selfAgentId];


Would like to discuss this change ?

Kesari3008 · 2026-08-19T15:26:36Z

Update Jira description with JIRA link, changes done and vidcast link for testing done in SDK

Update SDK functionality and tests

9fe3444

ajitkumar0828-spec requested a review from a team as a code owner August 18, 2026 09:04

chatgpt-codex-connector Bot reviewed Aug 18, 2026

View reviewed changes

Harden task departure detection for partial lifecycle events

2564fe9

chatgpt-codex-connector Bot reviewed Aug 19, 2026

View reviewed changes

ajitkumar0828-spec and others added 3 commits August 19, 2026 16:11

Merge branch 'next' into feature/participant-drop

84d7596

Preserve task state when partial participant rosters omit self

385b658

Improve contact center participant drop focus handling

d74caff

Kesari3008 requested changes Aug 19, 2026

View reviewed changes

Kesari3008 added the validated If the pull request is validated for automation. label Aug 19, 2026

Uh oh!

Conversation

ajitkumar0828-spec commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

I certified that

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

aws-amplify-us-east-2 Bot commented Aug 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 19, 2026

Choose a reason for hiding this comment

Uh oh!

Kesari3008 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kesari3008 commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ajitkumar0828-spec commented Aug 18, 2026 •

edited

Loading