-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(i18n): fill missing settings keys across 9 locales #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AvinashShrivastav
wants to merge
1
commit into
webadderallorg:main
Choose a base branch
from
AvinashShrivastav:fix/i18n-missing-keys-settings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,6 +45,11 @@ | |
| }, | ||
| "backgroundBlur": "Achtergrondvervaging", | ||
| "zoomMotionBlur": "Zoom-bewegingsonscherpte", | ||
| "temporalZoomMotionBlur": "Temporele zoom-bewegingsonscherpte", | ||
| "temporalZoomMotionBlurDescription": "Bepaalt het sluiterveld en de frame-steekproeven die worden gebruikt door de nieuwe zoom-vervagingsdoorgang.", | ||
| "zoomMotionBlurSamples": "Vervagingsmonsters", | ||
| "zoomMotionBlurShutter": "Sluiter", | ||
| "auto": "Auto", | ||
| "connectZooms": "Zooms verbinden", | ||
| "connectZoomsDescription": "Maak opeenvolgende zoomgebieden vloeiend tot een doorlopende camerabeweging.", | ||
| "autoApplyFreshRecordingZooms": "Zooms voor nieuwe opnames automatisch toepassen", | ||
|
|
@@ -57,6 +62,20 @@ | |
| "zoomOutDescription": "Bepaal hoe de camera een zoomgebied verlaat.", | ||
| "connectedZoomTitle": "Tussen zooms", | ||
| "connectedZoomDescription": "Stel de overgang af tussen opeenvolgende zoomgebieden wanneer verbinding is ingeschakeld.", | ||
| "motionPresetsTitle": "Bewegingsvoorinstellingen", | ||
| "motionPresetsZoomHint": "Zoom-bewegingsvoorinstellingen zijn beschikbaar in Instellingen.", | ||
| "animationPresets": "Animatievoorinstellingen", | ||
| "cursorMotionPresets": "Cursorbeweging-voorinstellingen", | ||
| "motionPresets": { | ||
| "focused": { | ||
| "label": "Gericht", | ||
| "description": "Snellere beweging voor demo's, walkthroughs en alledaagse opnames." | ||
| }, | ||
| "smooth": { | ||
| "label": "Vloeiend", | ||
| "description": "Rustigere beweging voor presentaties, keynote-stijl video's en verzorgde onthullingen." | ||
| } | ||
| }, | ||
| "zoomInDuration": "Inzoomduur", | ||
| "zoomInOverlap": "Inzoomoverlap", | ||
| "zoomOutDuration": "Uitzoomduur", | ||
|
|
@@ -74,7 +93,36 @@ | |
| }, | ||
| "cursorSize": "Cursorgrootte", | ||
| "cursorSmoothing": "Cursorverzachting", | ||
| "cursorSpringStiffness": "Cursorveerstarheid", | ||
| "cursorSpringDamping": "Cursorveerdempering", | ||
| "cursorSpringMass": "Cursorveermassa", | ||
| "off": "Uit", | ||
| "cursorClickEffects": { | ||
| "title": "Klikeffecten", | ||
| "advanced": "Geavanceerd", | ||
| "advancedShow": "Geavanceerde klikeffectinstellingen tonen", | ||
| "advancedHide": "Geavanceerde klikeffectinstellingen verbergen", | ||
| "color": "Effectkleur", | ||
| "size": "Effectgrootte", | ||
| "opacity": "Effectdekking", | ||
| "duration": "Effectduur", | ||
| "none": { | ||
| "label": "Geen", | ||
| "description": "Geen klikgrafiek. Alleen de cursorbeweiging verandert bij klikken." | ||
| }, | ||
|
Comment on lines
+109
to
+112
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Fix the typo in the Dutch click-effect description. Line 111 says 🤖 Prompt for AI Agents |
||
| "ripple": { | ||
| "label": "Ripple", | ||
| "description": "Uitdijende ringen stralen van elk klik zodat tikken duidelijk zichtbaar zijn." | ||
| }, | ||
| "spotlight": { | ||
| "label": "Spotlight", | ||
| "description": "Een zachte gloed flitst rond de aanwijzer om het aangeklikte gebied te accentueren." | ||
| }, | ||
| "echo": { | ||
| "label": "Echo", | ||
| "description": "Een paar zachte ringen die naar buiten uitdijen met een schonere puls." | ||
| } | ||
| }, | ||
| "cursorMotionBlur": "Cursor-bewegingsonscherpte", | ||
| "cursorClickBounce": "Cursorklikstuit", | ||
| "cursorClickBounceDuration": "Stuitsnelheid", | ||
|
|
@@ -127,8 +175,6 @@ | |
| "generateFull": "Ondertiteling genereren", | ||
| "regenerateFull": "Ondertiteling opnieuw genereren", | ||
| "clearFull": "Ondertiteling wissen", | ||
| "editCurrent": "Huidige ondertiteling bewerken", | ||
| "editSaved": "Ondertiteling bijgewerkt", | ||
| "fontSettings": "Lettertype-instellingen", | ||
| "defaultFont": "Standaard", | ||
| "fontFamily": "Lettertype", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Fix the garbled Korean copy before shipping.
Several new descriptions read as machine-corrupted Korean (
"세련된 레블","셋스러운","령이","훈레이션","포격적으로"), so these UI strings will be confusing for Korean users.✏️ Proposed wording
"motionPresets": { "focused": { "label": "집중", "description": "데모, 워크스루, 일상 녹화에 적합한 빠른 움직임." }, "smooth": { "label": "부드럽게", - "description": "프레젠테이션, 키노트 스타일 비디오, 세련된 레블에 적합한 부드럽고 셋스러운 움직임." + "description": "프레젠테이션, 키노트 스타일 영상, 정교한 연출에 어울리는 더 부드러운 움직임." } }, … "ripple": { "label": "리플", - "description": "클릭마다 확산되는 령이 탭이 명확하게 보이도록 합니다." + "description": "각 클릭에서 퍼져 나가는 링으로 탭 위치를 또렷하게 보여줍니다." }, "spotlight": { "label": "스포트라이트", - "description": "커서 주변에 부드러운 훈레이션이 활성화되어 클릭 영역을 강조합니다." + "description": "클릭한 영역을 강조하도록 커서 주변을 부드러운 후광으로 비춥니다." }, "echo": { "label": "에코", - "description": "더 깔끔한 팔스로 바깥쪽으로 포격적으로 퍼져나가는 부드러운 티 쌍의 링." + "description": "더 또렷한 펄스와 함께 바깥으로 퍼져 나가는 부드러운 이중 링입니다." }Also applies to: 113-123
🤖 Prompt for AI Agents