Skip to content

Fix AuthorName.setMiddleName to tolerate null middle names #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrj4001 merged 1 commit into from
Jul 6, 2026
Merged

Fix AuthorName.setMiddleName to tolerate null middle names #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/reciter/model/identity/AuthorName.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,16 @@ public void setFirstName(String firstName) {
* @param middleName the new middle name
*/
public void setMiddleName(String middleName) {
if (middleName == null)
throw new IllegalArgumentException("middle name should not be null.");
// Middle name is OPTIONAL (unlike first/last): many identities have none, so the stored
// attribute is null. A DynamoDB unconvert setter must tolerate null or the whole Identity
// fails to deserialize — e.g. findByUid threw DynamoDBMappingException ("could not unconvert
// attribute") -> 500 in ExternalArticleController.addExternalArticle for such people.
if (middleName == null) {
this.middleName = null;
this.middleInitial = "";
return;
}
//this.middleName = capitalize(middleName.trim().toLowerCase());
this.middleName = middleName.trim();
this.middleInitial = middleName.length() > 0 ? middleName.substring(0, 1) : "";
}
Expand Down
Loading