feat(warp): allow registering alternate CLI agents via WARP_CLI_AGENT_NAME - #76
Open
aovestdipaperino wants to merge 1 commit into
Open
feat(warp): allow registering alternate CLI agents via WARP_CLI_AGENT_NAME#76aovestdipaperino wants to merge 1 commit into
aovestdipaperino wants to merge 1 commit into
Conversation
…_NAME build-payload.sh hard-coded the payload's agent slug to "claude", so any harness reusing these hook scripts was mislabeled in Warp's session UI and notifications. Read the slug from WARP_CLI_AGENT_NAME (default "claude") so agents like plank, which speak the same warp://cli-agent OSC 777 protocol, register under their own identity. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-payload.shhard-codes the payload'sagentslug to"claude", so any harness that reuses these hook scripts is mislabeled in Warp's session UI and notifications.This PR reads the slug from
WARP_CLI_AGENT_NAME(defaulting toclaude, so existing behavior is unchanged) so agents that speak the samewarp://cli-agentOSC 777 protocol — e.g. plank — can register under their own identity.Changes
plugins/warp/scripts/build-payload.sh: agent slug fromWARP_CLI_AGENT_NAME, defaultclaudeplugins/warp/tests/test-hooks.sh: assert the override works and that an empty value falls back toclaudeTesting
./plugins/warp/tests/test-hooks.sh— 59 passed, 0 failed.🤖 Generated with Claude Code