fix: Change default highestUserWastedPercent to disabled#708
Open
GautamKumarOffical wants to merge 1 commit into
Open
Conversation
When highestUserWastedPercent is commented out in the .dive-ci config, the rule was not being skipped but instead used the default value of 0.1. This was inconsistent with highestWastedBytes which defaults to 'disabled' and is properly skipped when commented out. Changed the default value from '0.1' to 'disabled' to make the behavior consistent. Users who want this rule active must now explicitly set it in their config file. Closes wagoodman#606 Signed-off-by: Gautam Kumar <gautamkumarofficial@users.noreply.github.com>
Author
|
Hi! This PR changes the default highestUserWastedPercent to disabled. All checks pass. Happy to make any adjustments. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
highestUserWastedPercentis commented out in the.dive-ciconfig file, the rule was not being skipped as expected. Instead, it used the default value of0.1, which caused CI failures even though the user intended to disable that rule.This behavior was inconsistent with
highestWastedBytes, which defaults to"disabled"and is properly skipped when commented out.Changes
highestUserWastedPercentfrom"0.1"to"disabled"inDefaultCIRules()dive-fail.yamlto explicitly set the rule since the default changedBefore
After
The commented-out rule is now properly skipped, making the behavior consistent across all CI rules.
Closes #606