fix[venom]: type state variable reads with the declared type - #5239
Merged
harkal merged 7 commits intoSep 8, 2026
Merged
Conversation
Gas ChangesNo changes detected. Summary
|
📊 Bytecode Size Changes (venom)No changes detected. Full bytecode sizes
|
harkal
marked this pull request as ready for review
September 4, 2026 10:31
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a23d740576
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
charles-cooper
left a comment
charles-cooper
left a comment
Member
There was a problem hiding this comment.
hmm it's a bit surprising that this changes behavior. @Sporarum can you take a look?
harkal
requested review from
HodanPlodky and
charles-cooper
and removed request for
Sporarum
September 4, 2026 14:52
HodanPlodky
approved these changes
Sep 7, 2026
Sporarum
reviewed
Sep 8, 2026
Sporarum
left a comment
Sporarum
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
The one question I have, is why only those specific cases ?
I'm also having issues with ternary ifs, and I think the root cause is the same
Sporarum
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix a venom-only miscompile when a storage, transient or immutable variable is
read into a wider type, e.g.
ys: DynArray[Bytes[512], 5] = self.storedwithstored: DynArray[Bytes[10], 5]. Same bug family as #5236.The semantic pass stamps the
self.x/lib.Xnode with the expected(widened) type.
codegen_venomused that type to describe the borrowed pointerto the state variable, but the data has the declared type's layout. Two things
went wrong:
load_storage_to_memorysized the copy loop from the widetype (86 slots for
DynArray[Bytes[512], 5]vs the declared 11), readingslots that belong to neighbouring variables;
(544 bytes vs 64), so every element after the first was garbage.
For
[b'a', b'0123456789', b'']this returned[b'a', b'', b'']; other shapeshalted out of gas. Immutables had the same defect via
load_immutable_to_memory. Legacy codegen is unaffecthese IRnodes with
varinfo.typ.How I did it
Type the pointer returned by
lower_Attribute(state variable reads) andlower_Name(immutable reads) with the variable's denode._metadata["type"]. The existing typed copies on the consumer side(
store_memory(..., src_typ=...), `_store_complex_tyreturn encoding, call args) then widen element-wise. No new copy machinery.
Not covered here:
for x: <wide> in self.storedcopies each element linearlyin
_lower_iter_loopand has the same class of bug fwidenings. That is a separate code path and will be a separate PR.
How to verify it
Commit message
Description for the changelog
Cute Animal Picture