tests?

[r00t-]

[r00t-]

there currently are some basic unit tests using the unity test framework

we probably want to get some real-world example data and make tests from that.

[mbehr1]

I'd prefer this as well. But to get some real-world examples we need a logging facility for the real data coming from the serial port.

[devZer0]

https://github.com/devZer0/libsml-testing

[andig]

https://github.com/devZer0/libsml-testing

Interesting. @devZer0 did you by chance open a bug for the libsml crash?

[devZer0]

it's a while ago that i worked with all that stuff. need to find my sources for commandline parser tool i tried to develop. if i find it and compile it against latest libsml and it still crashes, i will file a bug report. not sure why i didn't at that time....

[devZer0]

what about adding my libsml-testing sml binary dumps to the volkszaehler-git repo or even add those test files to libsml repo ? think that would raise awareness....

furthermore, i found a way to somewhat simulate a serial port, even with setting a virtual baudrate - this way parser tools can be tested which do not support reading from a file or from stdin or developers can test an application with smartmeters they don't have physical access to.

maybe there are even better settings for socat, didn't test into depth, but basically it works and i think this is quite interesting/useful:

---

To simulate a eHz/Smart-Meter for development or troubleshooting, you can to the following:

1. get socat and execute
   # socat -d -d pty,raw,echo=0 pty,raw,echo=0

   socat will connect two pty's and look like this:

   # socat -d -d pty,raw,echo=0 pty,raw,echo=0
2018/01/20 22:08:48 socat[8029] N PTY is /dev/pts/6
2018/01/20 22:08:48 socat[8029] N PTY is /dev/pts/9
2018/01/20 22:08:48 socat[8029] N starting data transfer loop with FDs [5,5] and [7,7]

2. connect your favourite SML parser/tool to one of the pty's socat did attach to:

   # ./sml_server /dev/pts/6

3. now feed a binary sml dump to the other pty's:

   # cat EMH_eHZ-GW8E2A500AK2.bin >/dev/pts/9

   you can throttle the data rate with "pv" (pipe viewer):

   # cat EMH_eHZ-GW8E2A500AK2.bin | pv -L 9600 >/dev/pts/9

4. watch output from your favourite SML parser/tool or troubleshoot/debug...

[andig]

Warum nicht einfach den. Dump einlesen? Woher die dumps- aus Deinem Repo?

[devZer0]

weil es tools geben könnte die nicht von file oder stdin lesen können, weil sie nur auf serielle schnittstelle ausgelegt sind? so wie sml_server bis vor kurzem?

ja, ich meine die dumps aus meinem repo. wenn "testing" bei libsml ne rolle spielt wäre ansonsten ein verweis hilfreich, es wär ja schön wenn die dump-sammlung noch etwas wachsen würde...

[andig]

weil es tools geben könnte die nicht von file oder stdin lesen können, weil sie nur auf serielle schnittstelle ausgelegt sind? so wie sml_server bis vor kurzem?

Dann ist das ein Designfehler :)

es wär ja schön wenn die dump-sammlung noch etwas wachsen würde...

Gerne! Magst Du einen PR machen?

[andig]

@devZer0 I'd be happy to include your collected dumps in this repo as "real life" test data. Is that ok for you?

[hmueller01]

I do not think that dumps belong in a lib repository. They should be kept separately with a link in the Readme.md.

Reason: Not all users need this just to compile the lib ...

[andig]

I do not think that dumps belong in a lib repository. They should be kept separately with a link in the Readme.md.

I still think its a good proposal for testing. How else?

[hmueller01]

Yes, they are. And it is good that they exist. But not needed by everyone, as I added on my last post.