Repository navigation
fix: reject empty Kubernetes resource names in tRPC input schemas - #400
Open
AnKiT-GaRG2 wants to merge 1 commit into
Open
AnKiT-GaRG2 wants to merge 1 commit into
AnKiT-GaRG2 wants to merge 1 commit into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Welcome @AnKiT-GaRG2! It looks like this is your first PR to volcano-sh/dashboard 🎉 |
Add a shared k8sIdentifierSchema (trimmed, min length 1) for the name and namespace of get/update/delete inputs for jobs, pods, queues and podgroups. List, pagination and filter schemas are unchanged. The YAML detail views used disabled queries initialised from the previous selection, so the first click sent empty identifiers. Fetch the YAML with the clicked row's identifiers instead so the modals keep working with the stricter schemas. Signed-off-by: Ankit Garg <146389256+AnKiT-GaRG2@users.noreply.github.com>
AnKiT-GaRG2
force-pushed
the
fix/287-reject-empty-k8s-identifiers
branch
from
October 22, 2026 16:54
aea822a to
213f551
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #287
k8sIdentifierSchema(z.string().trim().min(1)) and uses it fornameandnamespaceon the get/update/delete inputs for jobs, pods, queues and podgroups (queues onlyname). List, pagination and filter schemas are unchanged.utils.<router>.<proc>.fetch(...), as the edit handlers already do, and the unused queries are removed.turbo run check-types lintpasses (only the existinguseCallbackdependency warnings). A quick script confirmed empty and whitespace-only names are rejected and valid ones accepted. I did not test the modals in a browser, and there is no test setup in the repo.AI disclosure: an AI coding assistant helped prepare this change. The checks above were run locally.