Apply-MegatronAdaptor-NPU-migration-to-clean-branch - #385
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request transitions the NPU training stack from MindSpeed to MegatronAdaptor and TransformerEngineNPU, updates the Megatron-LM commit, and applies several patches for optimizer steps, memory pool regions, and vLLM speculative draft updates. The reviewer's feedback is highly actionable and should be addressed: the new megatron_bridge.patch is orphaned in the Dockerfile and lacks path resolution in the environment update script; cloning dependencies from main without pinning commits makes the Docker build fragile; and the run-qwen3-4B-npu.sh script contains several hardcoded absolute paths and NPU device IDs that break portability.
Documentation build overview
48 files changed ·
|
Signed-off-by: wangxiaoxin-sherie <wangxiaoxin7@huawei.com>
1 participant
Summary
Files Changed
vime/backends/megatron_utils/vime/utils/docker/scripts/examples/tests/train.pytrain_async.py