Adds mailhog make command#97
Closed
andersonresende wants to merge 1 commit into
Closed
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a new Makefile target to start the MailHog server via Docker and keeps existing frontend test target unchanged functionally. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The new
docker-up-mailhogtarget is defined without any commands, so running it will be a no-op; consider adding the appropriate$(DOCKER_COMPOSE) ...invocation or making it depend on an existing target that actually starts Mailhog.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `docker-up-mailhog` target is defined without any commands, so running it will be a no-op; consider adding the appropriate `$(DOCKER_COMPOSE) ...` invocation or making it depend on an existing target that actually starts Mailhog.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Screenshots (if appropriate):
Steps to reproduce (if appropriate):
Types of changes
Checklist:
Summary by Sourcery
Enhancements: