Conversation
| #' @export | ||
| gen_combined_df <- function(prev_dat, df2, interest_cols, key_cols) { | ||
| # TODO: input checks | ||
| # TODO: df2 needs a better name |
There was a problem hiding this comment.
df2 is essentially a cleaned version of of the touchstone_new latest report on packit where vaccine names are cleaned, subregions appended etc. happy to take suggestions on a better way to do it
There was a problem hiding this comment.
Thanks - could you suggest an informative name for the argument that somebody new to the package and the workflow would understand? data_current? data_cleaned? If you could pop a couple of lines in this thread about any expectations around it, I can add those to the function docs.
There was a problem hiding this comment.
df_clean is fine, thanks. df_clean is the imported dependency report (currently named touchstone_new) with the following cleaning steps applied:
- Malaria vaccine names amended
- Subregions appended
- Fixes for missing country names
- Removal of now-redundant columns
It may even be sufficient to just apply these steps todfitself, I think I just kept them separate when developing the report so I didn't have to keep pulling a clean dependency when testing things out.
|
This pull request:
Reach out on slack ( (Note that results may be inaccurate if you branched from an outdated version of the target branch.) |
WIP as PR develops.