Skip to content

WIP adding pressure testing#14

Draft
pratikunterwegs wants to merge 17 commits intomainfrom
develop
Draft

WIP adding pressure testing#14
pratikunterwegs wants to merge 17 commits intomainfrom
develop

Conversation

@pratikunterwegs
Copy link
Copy Markdown
Contributor

WIP as PR develops.

Comment thread R/fn_pressure_testing.R Outdated
Comment thread R/constants.R Outdated
Comment thread R/fn_pressure_testing.R Outdated
Comment thread R/fn_pressure_testing.R Outdated
#' @export
gen_combined_df <- function(prev_dat, df2, interest_cols, key_cols) {
# TODO: input checks
# TODO: df2 needs a better name
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

df2 is essentially a cleaned version of of the touchstone_new latest report on packit where vaccine names are cleaned, subregions appended etc. happy to take suggestions on a better way to do it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - could you suggest an informative name for the argument that somebody new to the package and the workflow would understand? data_current? data_cleaned? If you could pop a couple of lines in this thread about any expectations around it, I can add those to the function docs.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

df_clean is fine, thanks. df_clean is the imported dependency report (currently named touchstone_new) with the following cleaning steps applied:

  • Malaria vaccine names amended
  • Subregions appended
  • Fixes for missing country names
  • Removal of now-redundant columns
    It may even be sufficient to just apply these steps to df itself, I think I just kept them separate when developing the report so I didn't have to keep pulling a clean dependency when testing things out.

Comment thread R/fn_pressure_testing.R Outdated
@github-actions
Copy link
Copy Markdown

This pull request:

  • Adds 4 new dependencies (direct and indirect)
  • Adds 1 new system dependencies
  • Removes 0 existing dependencies (direct and indirect)
  • Removes 0 existing system dependencies

Reach out on slack (#code-review or #help channels) to double check if there are base R alternatives to the new dependencies.

(Note that results may be inaccurate if you branched from an outdated version of the target branch.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants