Repository navigation
fix(docs): use a local SVG for the asciinema demo in README - #770
Open
Prince-Dany wants to merge 1 commit into
Open
Prince-Dany wants to merge 1 commit into
Prince-Dany wants to merge 1 commit into
Conversation
GitHub's image proxy fails to fetch the asciinema.org SVG, showing a broken image. Commit the SVG to the repository and reference it locally so the demo renders reliably. Closes version-fox#760 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
linghengqian
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
=======================================
Coverage 56.62% 56.62%
=======================================
Files 116 116
Lines 8595 8595
=======================================
Hits 4867 4867
Misses 3263 3263
Partials 465 465 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
linghengqian
requested changes
Nov 14, 2026
linghengqian
left a comment
linghengqian
left a comment
Member
There was a problem hiding this comment.
Could you remove Claude from the list of co-authors? It makes it difficult to track the actual contributors later on.
linghengqian
added
need-more-info
and removed
bug
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
README.mdandREADME_CN.mdshows a broken image because GitHub's image proxy (camo.githubusercontent.com) cannot fetch the SVG fromasciinema.org.Changes
demo.svg— the asciinema recording SVG (downloaded fromhttps://asciinema.org/a/650100.svg)README.mdline 34: changed image source from the external URL todemo.svgREADME_CN.mdline 30: same changeWhy
GitHub's image proxy returns
503 Error Fetching Resourcefor the asciinema SVG. The issue documents 7/7 failed proxy attempts vs. direct requests succeeding. Committing the SVG locally bypasses the proxy entirely.Testing
<?xml version="1.0"?>header, proper SVG namespace)Closes #760
🤖 Generated with Claude Code