Turbopack: improve Pat::Assign modelling in analyzer - #97867
Merged
Conversation
Contributor
Tests PassedCommit: 3e9b109 |
Contributor
Stats from current PR🔴 3 regressions
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
Build Cache
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URLCommit: 3e9b109 |
mischnic
changed the title
mischnic
marked this pull request as ready for review
August 25, 2026 12:34
sokra
reviewed
Aug 25, 2026
| self.arena, | ||
| self.eval_context.eval(self.arena, &assign.right), | ||
| ); | ||
| self.with_pat_value(Some(value), |this| { |
Member
There was a problem hiding this comment.
let mut ast_path =
ast_path.with_guard(AstParentNodeRef::AssignPat(n, AssignPatField::Left));
Member
Author
There was a problem hiding this comment.
I would only need to do that if I were using
assign.left.visit_with_ast_path(this, ast_path);but I'm doing
pat.visit_children_with_ast_path(self, ast_path)and the visit_children will handle this for me.
(Just like in the else branch right below)
sokra
approved these changes
Aug 25, 2026
sokra
left a comment
sokra
left a comment
Member
There was a problem hiding this comment.
Approved when the ast path is fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of the argument is actually
Argument | Default value. Previously, thetake_pat_valuewould take it and the recursivevisit_patwould not see it anymore.