Skip to content

Localize progress messages#1610

Merged
MaximPlusov merged 1 commit into
integrationfrom
localize-progress-messages
Jul 8, 2026
Merged

Localize progress messages#1610
MaximPlusov merged 1 commit into
integrationfrom
localize-progress-messages

Conversation

@Vladimir-Burshnev

@Vladimir-Burshnev Vladimir-Burshnev commented Jun 19, 2026

Copy link
Copy Markdown

Closes: https://trello.com/c/UUSavtcl
FE PR: https://github.com/duallab/pdf4wcag-webapp-gui/pull/221
BE PR: https://github.com/duallab/pdf4wcag-webapp-server/pull/57
wcag-algs PR: veraPDF/veraPDF-wcag-algs#385

Summary by CodeRabbit

  • New Features
    • Added a new way to view validation progress statistics during PDF/A checks.
    • Exposed current counters such as total checks, failed checks, processed objects, and remaining objects.
    • Enabled validation progress data to be retrieved through the validator API for easier status reporting.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 514ec89e-3c3a-4f30-866a-2bf1628217ab

📥 Commits

Reviewing files that changed from the base of the PR and between 49cef3c and ab1fd76.

📒 Files selected for processing (3)
  • core/src/main/java/org/verapdf/core/utils/ValidationProgress.java
  • core/src/main/java/org/verapdf/pdfa/PDFAValidator.java
  • core/src/main/java/org/verapdf/pdfa/validation/validators/BaseValidator.java

📝 Walkthrough

Walkthrough

Adds a getValidationProgressStats() capability spanning ValidationProgress, the PDFAValidator interface, and BaseValidator. ValidationProgress gains getCurrentValidationJobStats() building a Map of check/processing counters; the interface declares the new method, and BaseValidator implements it by delegating to ValidationProgress.

Changes

Validation Progress Stats

Layer / File(s) Summary
Core stats builder
core/src/main/java/org/verapdf/core/utils/ValidationProgress.java
Adds getCurrentValidationJobStats() returning a Map<String, Object> with checks, failedChecks, processedObjects, and objectsToBeProcessed counters.
Interface and implementation wiring
core/src/main/java/org/verapdf/pdfa/PDFAValidator.java, core/src/main/java/org/verapdf/pdfa/validation/validators/BaseValidator.java
Declares getValidationProgressStats() on the PDFAValidator interface and implements it in BaseValidator by delegating to ValidationProgress.getCurrentValidationJobStats().

Estimated code review effort: 1 (Trivial) | ~5 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant BaseValidator
  participant ValidationProgress
  Caller->>BaseValidator: getValidationProgressStats()
  BaseValidator->>ValidationProgress: getCurrentValidationJobStats()
  ValidationProgress-->>BaseValidator: Map of counters
  BaseValidator-->>Caller: Map of counters
Loading
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions localizing progress messages, but the diff adds validation progress stats API methods instead. Rename the title to reflect the actual change, such as adding validation progress statistics methods.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch localize-progress-messages

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MaximPlusov
MaximPlusov force-pushed the localize-progress-messages branch from cb3f147 to ab1fd76 Compare July 8, 2026 11:39
@MaximPlusov
MaximPlusov merged commit 3191f4a into integration Jul 8, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants