Reject path components that contain a slash - #155
Closed
TastyHeadphones wants to merge 1 commit into
Closed
TastyHeadphones wants to merge 1 commit into
TastyHeadphones wants to merge 1 commit into
Conversation
A component like "te/st" used to register as a single unreachable segment. Fail fast instead so callers use separate components.
Member
|
After some discussions with the community I think we should allow the |
Member
|
Will close this since and if you're up for it, open a new PR that solves it, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path components with a
/in them (e.g.app.get("te/st")) used to register as one segment that nothing could match.That shows up as a silent 404 — see vapor/vapor#3349. Maintainer guidance there was that those components shouldn't be accepted.
This fails at init with a clear message so you use
app.get("te", "st")instead.String.pathComponentsis unchanged (it splits on/first).Fixes vapor/vapor#3349