fix: migrate flat autoscaler_lxd_* keys to nested vantage_lxd_autoscaler - #61
Merged
Conversation
The settings dict was still writing/reading flat keys like autoscaler_lxd_default_network, autoscaler_lxd_client_cert_data, etc. These must be nested under vantage_lxd_autoscaler to match the new VDeployerSettings schema. - create.py: write creds/defaults into vantage_lxd_autoscaler sub-dict - create.py: validation checks nested path for default_network - app.py: _asc() helper reads from nested vantage_lxd_autoscaler block - cloud_init keys moved to vantage_lxd_autoscaler.cloud_init sub-dict - Test fixtures updated to nested format Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings dict was still writing/reading flat keys like autoscaler_lxd_default_network, autoscaler_lxd_client_cert_data, etc. These must be nested under vantage_lxd_autoscaler to match the new VDeployerSettings schema.