refactor: rename node_groups to compute_pools, migrate to nested settings - #59
Merged
Merged
Conversation
…ings
- CLI flags: --admin-node-group → --admin-compute-pool,
--control-node-group → --control-compute-pool, --node-group → --compute-pool
- Settings: flat f"{service}_enabled" pattern replaced with nested path
lookup via _SERVICE_SETTING_PATH mapping (slurm.enabled, mlflow.enabled,
kuberay.enabled, etc.) with get_nested/set_nested helpers
- default_control_node_groups (list) → default_control_plane_compute_pool
(single object) in LXD slurm provider
- Deleted dead compute_pool/node_group/ subpackage (not registered)
- All 106 tests pass
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--admin-node-group→--admin-compute-pool,--control-node-group→--control-compute-pool,--node-group→--compute-pool{service}_enabledpattern replaced with nested path lookup via_SERVICE_SETTING_PATHmapping (slurm.enabled,mlflow.enabled,kuberay.enabled, etc.) withget_nested/set_nestedhelpersdefault_control_node_groups(list) →default_control_plane_compute_pool(single object) in LXD slurm providercompute_pool/node_group/subpackage (not registered in CLI)Test plan
uv run pytest— 106 tests passv8x cluster service enable slurmwritesslurm.enabled: true(nested)v8x cluster service disable mlflowwritesmlflow.enabled: false(nested)🤖 Generated with Claude Code