Percentage token has .tvalue as float#239
Open
jnwltr wants to merge 1 commit into
Open
Conversation
Collaborator
|
This really requires tests... Also if the code was rebased/merged with master, the CI tests should now pass. |
- `str` was expected - e.g. `=IF(RANGE>75%; 1; 0)` fails since `75%` is translated to .75 - while `=IF(RANGE>.75; 1; 0)` would translate to '0.75'
jnwltr
force-pushed
the
fix/percentage-token
branch
from
2e8e866 to
3b71381
Compare
Author
|
I'll gladly write a test. So create |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strwas expected=IF(RANGE>75%; 1; 0)fails since75%is translated to0.75=IF(RANGE>.75; 1; 0)would translate to'0.75'