Skip to content

feat(isNumeric): add support for thousand separator option#2711

Open
PepiPetrov wants to merge 3 commits into
validatorjs:masterfrom
PepiPetrov:master
Open

feat(isNumeric): add support for thousand separator option#2711
PepiPetrov wants to merge 3 commits into
validatorjs:masterfrom
PepiPetrov:master

Conversation

@PepiPetrov
Copy link
Copy Markdown

This fixes #1433 and resolves merge conflicts of #1476 .

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.96%. Comparing base (7fdc788) to head (9deb113).

Files with missing lines Patch % Lines
src/lib/isNumeric.js 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2711      +/-   ##
===========================================
- Coverage   100.00%   99.96%   -0.04%     
===========================================
  Files          114      114              
  Lines         2587     2593       +6     
  Branches       656      659       +3     
===========================================
+ Hits          2587     2592       +5     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PepiPetrov PepiPetrov mentioned this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate thousand separator is displayed for numbers

2 participants