fix: auto-load route from URL parameters#409
Open
Rohiyadaop wants to merge 2 commits intovalhalla:masterfrom
Open
fix: auto-load route from URL parameters#409Rohiyadaop wants to merge 2 commits intovalhalla:masterfrom
Rohiyadaop wants to merge 2 commits intovalhalla:masterfrom
Conversation
a-y-a-n-das
reviewed
Apr 1, 2026
Contributor
a-y-a-n-das
left a comment
a-y-a-n-das
left a comment
There was a problem hiding this comment.
I think these lockfile changes are unintended.
|
Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/409 |
Author
Removed the unintended lockfile changes in 7c24ccd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Auto-load route from URL parameters
Fixes Issue
Closes #394
Changes proposed
Parse
wpsURL parameters on initial page loadHydrate waypoints using reverse geocoding
Automatically render route when:
Moved URL parsing logic from
DirectionsControltoAppPrevent duplicate execution using
useRefAdded unit tests for:
Note to reviewers
This fix ensures that when a saved route URL is opened, the route is automatically displayed without requiring manual interaction.