Repository navigation
fix(media): refresh projected token paths before Azure authentication - #40
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP can keep a resolved path to an old projected workload token after its directory symlink rotates. Azure media copies then fail when the SDK reads that removed target. Refresh the realpath cache immediately before every Azure token acquisition, including calls from retained workers.
A small credential wrapper delegates to the existing SDK through the shared singleton binding. Authentication context, results and exceptions retain their existing behavior. No permissions, storage settings, dependencies or database schema change.
Validation: 81 focused PostgreSQL tests passed, covering repeated external token rotation, missing/unreadable files, credential delegation, media copying, Azure reads and SAS signing. Removing the cache refresh reproduces the token-read exception. Pint and the staged secret scan pass. Opengrep reports only cleanup of a generated temporary test file. Screenshots do not apply because this changes no UI.
All ten hosted checks passed on this head, including both database engines and all browser shards. Independent final source review passed with no findings. The PR remains draft pending named merge/release/deployment approval and live duplication acceptance. The cache refresh adds unmeasured path-resolution work during token acquisition; it does not add retries or guarantee against a rotation racing the read.
Implementation plan