Skip to content

enhance(ideas): add writing style selection to generation - #38

Merged
rschlaefli merged 4 commits into
release/2.0.0-uzhfrom
rs/trypost-idea-writing-styles
Oct 27, 2026
Merged

rschlaefli merged 4 commits into
release/2.0.0-uzhfrom
rs/trypost-idea-writing-styles

Conversation

@rschlaefli

@rschlaefli rschlaefli commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Ideas generation offered model selection but no writing-style choice. This adds the existing Default/DF selector and passes the selected guide into the original structured generation request.

The writing assistant and Ideas share one selector. Default retains existing behavior; invalid or unavailable styles fail before generation. Results remain title/body idea briefs, with no schema or provider changes.

Screenshots

Local synthetic application: English desktop (1280×900) and German phone (390×844). Captured at 8e29b85c; the final candidate changes only a dead test guard, with identical rendered application source. Provider responses are synthetic; these images do not demonstrate real model writing quality.

State Desktop · English Phone · German
Model and style selection Model and style selection with DF style on Desktop · English Model and style selection with DF style on Phone · German
Generated idea brief Generated idea brief with DF style on Desktop · English Generated idea brief with DF style on Phone · German

Validation: 108 focused backend tests; two Ideas browser cases and four existing assistant browser cases; Pint, frontend formatting/lint, TypeScript and the asset build. Browser checks cover model/style pairing, regeneration, switching to Default, save and reopening/reset. Independent source review is complete; its one advisory test cleanup is applied.

The focused Opengrep scan found no rule issues. Its parser rejects readonly constructor promotion; that class also passed a scan-only copy omitting the modifier, native PHP checks and direct source review.

Tests and lint passed on e5cc9ef6, including PostgreSQL, MySQL and the full browser suite. Paid model quality and deployment are outside this verification. Implementation plan.

@rschlaefli
rschlaefli marked this pull request as ready for review October 27, 2026 17:56
Copilot AI balanced review requested due to automatic review settings October 27, 2026 17:56
@rschlaefli
rschlaefli merged commit d4ddb3f into release/2.0.0-uzh Oct 27, 2026
10 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants