Skip to content

jets: refcount fixes caught by a linter#1058

Open
dozreg-toplud wants to merge 4 commits into
developfrom
dozreg/more-refcount-fixes
Open

jets: refcount fixes caught by a linter#1058
dozreg-toplud wants to merge 4 commits into
developfrom
dozreg/more-refcount-fixes

Conversation

@dozreg-toplud

@dozreg-toplud dozreg-toplud commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Some refcount bugs caught by a linter (WIP):

  • bytestream.c: we lose retained octs_list;
  • chacha: forgot to increment the refcount of retained wid, didn't test wid and dat for being atoms
  • hmac: didn't test out for being a direct atom even though the code clearly assumes it; missing c3_w -> atom conversions
  • mat/rub/scow: plain leaks
  • shax: confusion between retained c and owned d
  • slaw: leaks, assumptions that numname is a direct atom (so no u3k(year)) but no checks; better fix is to just get rid of leaks by not having generic macros
  • urwasm: leaks in run_once, saner control flow which is more readable for a linter and a human;
  • u3z_uniq: leaked key
  • loss.c: an atom was used as direct with no check

@dozreg-toplud
dozreg-toplud requested a review from a team as a code owner July 8, 2026 18:33
@dozreg-toplud dozreg-toplud mentioned this pull request Jul 9, 2026
2 tasks
@dozreg-toplud
dozreg-toplud force-pushed the dozreg/more-refcount-fixes branch from 536e2f2 to 60fa7cf Compare July 20, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant