Skip to content
This repository was archived by the owner on May 23, 2025. It is now read-only.

feature/yarn-workspaces#103

Open
rbnts wants to merge 10 commits into
developfrom
feature/yarn-workspaces
Open

feature/yarn-workspaces#103
rbnts wants to merge 10 commits into
developfrom
feature/yarn-workspaces

Conversation

@rbnts

@rbnts rbnts commented Jan 22, 2021

Copy link
Copy Markdown
Member
  • switch out lerna in favor of yarn workspaces
  • remove unnecessary dependencies
  • remove unnecessary config files
  • clean up metadata and file structure

@rbnts rbnts requested a review from lbsonley January 22, 2021 10:03
@rbnts rbnts changed the title Feature/yarn workspaces [wip] feature/yarn-workspaces Jan 22, 2021
@rbnts rbnts changed the title [wip] feature/yarn-workspaces feature/yarn-workspaces Jan 28, 2021

@lbsonley lbsonley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check travis build logs for graphicmagick related error. Add it back to travis.yml if needed

Comment thread .travis.yml

before_install:
- sudo apt-get update
- sudo apt-get install graphicsmagick

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to install graphicsmagick for the image optimization task.

Comment thread .travis.yml
language: node_js

node_js:
- "14"

@lbsonley lbsonley Jan 29, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should consider adding multiple node versions here. Travis will do a build for each version listed. I think we should keep all LTS versions of node here. This way we can say we support LTS.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, let's go for 12.x and 14.x

@lbsonley

Copy link
Copy Markdown
Collaborator

@robinloeffel , I forgot to bump the engines prop in package.json everywhere when I did the node upgrade. Since we are updating the travis config for node version, I think we should bump the engines field for all packages.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Robin Löffel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants