This repository was archived by the owner on Oct 16, 2023. It is now read-only.
Repository navigation
Instead of depending on render we depend on a dynamic component - #1
Merged
Merged
Conversation
…rendering a dynamic component
```
{{#each modals as |modal|}}
{{component-apply modal.name modal.args}}
{{/each}}
```
It keeps the state of the modals within the controller in a modals array.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of rendering an outlet this will create an array on the application controller called
modals. This will get new entries when modals are created.This removes our outlet, view and controller that was just a proxy to the component itself. So the actual component is simply rendered. You have to use component-apply until ember finishes the pull request for splat support.