Repository navigation
Stop repeating the code in Expense Review export names - #124
Merged
Merged
Conversation
ChartSegments.ValueDesc is always Code - Description, so UCPath rows in Expense Review and the pre-association totals Name column showed the code twice. Read Description instead, which matches what AE transactions carry. Some AE project names already start with their code. The CSV writer now writes those names as-is instead of adding the code again. Fixes #122 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
sprucely
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122
Cause
UCPath rows got their segment names from
ChartSegments.ValueDesc, falling back toDescription. In DataDb,ValueDescis exactlyCode - Descriptionon every row in all 8 segments, so the CSV writer'sCode - Namecame out as1000001 - 1000001 - Central Office AP. AE rows read their own description columns, which matchChartSegments.Description, so only some rows showed the problem.The pre-association totals Name column had the same
ValueDesclookup.Changes
ExpenseReviewService: UCPath rows readDescriptionfor all 8 segments. This also fixes the filter dropdown labels for UCPath rows.AutoAssociationReportService: the pre-association totals department name readsDescription.ExpenseReviewCsvWriter: some AE project names already start with their code, for exampleSP0A241267 - Hernandez # R02CP7556. Those names are written as-is instead of getting the code added again.ValueDescits realCode - Descriptionshape. New checks cover UCPath row names and the CSV project case.ValueDescis still imported and the schema is unchanged, so no reimport is needed.Not in this PR
The Expense Review filter dropdowns build their labels in SQL, so project names that already start with their code still show it twice there.
Testing
dotnet test: 451 passed. The three new or changed tests failed before the fix.🤖 Generated with Claude Code