Repository navigation
Let the classification loader fill unset rows on a populated table - #114
Draft
rmartinsen-ucd wants to merge 1 commit into
Draft
rmartinsen-ucd wants to merge 1 commit into
rmartinsen-ucd wants to merge 1 commit into
Conversation
… empty table The import seeds every code as unclassified, so on test the table is never empty and the loader refused to run. It now classifies rows that are still unset, inserts missing codes, never changes a row that already has a classification, and lists kept rows that disagree with the CSV. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
sprucely
approved these changes
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The import seeds every code as unclassified, so on test the classification table is never empty, and
load-classifications.pyrefused to run. As a result, test shows about 2,400 unclassified codes that the CSV already classifies.The loader now:
Nothing else changed. It works on an empty table as before, and running it again is a no-op.
I also checked that the CSV matches local DataDb exactly: there are no differing values, and the only extra local rows are unclassified codes added by the seed.
Test plan
🤖 Generated with Claude Code