Repository navigation
Read Data Classification levels from ChartSegments and drop the hierarchy tables - #113
Merged
Merged
Conversation
…rchy tables The five hierarchy tables were seeded once from small CSVs, so only a few hundred of the thousands of imported codes had levels and the rest showed blank in Data Classification. ChartSegments already holds every code's parent levels from the AE warehouse, refreshed on each import, and every parent code resolves to a named row in the same segment. Where the two overlapped, all 349 seeded rows matched it exactly. The grid now builds levels from ChartSegments, the way OrgR Review does, lettered A down by level with self-repeating levels left out. The hierarchy tables, their entities, HierarchySeed and the seed CSVs are removed. The pre-deployment script clears the tables first so the publish can drop them under BlockOnPossibleDataLoss. The dev seed no longer derives Account, Fund, Activity and Department rows from the hierarchy tables; the import seeds those. It still seeds ERN codes and the 2025 purpose rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
rmartinsen-ucd
marked this pull request as ready for review
October 21, 2026 14:08
sprucely
approved these changes
Oct 21, 2026
sprucely
left a comment
sprucely
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Didn't fully test, having trouble getting past the PGM import. Something is slowing things down on my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data Classification showed blank levels for nearly every code. The five hierarchy tables were seeded once from small CSVs (182 accounts, 110 funds, 39 activities, 18 purposes, 1 department), while the grid lists thousands of codes from imported transactions. On test the tables are empty, since the seed only runs in development.
ChartSegments already has what the levels need. It is refreshed on every import, every parent code resolves to a named row in the same segment, and all 349 seeded rows matched it exactly where the two overlapped. Local coverage goes from 1 to 2,886 of 2,903 departments, 182 to 2,071 of 2,078 accounts and 107 to all 1,648 funds.
Changes:
ERN codes still have no levels, since no hierarchy exists for them.
Tests: dotnet test passes, 450 of 450, including the SQL integration tests.
🤖 Generated with Claude Code