Repository navigation
Show only codes that can change the report in Data Classification - #111
Merged
Merged
Conversation
New view v_ClassificationCandidates lists the chart-string codes on at least one transaction that passes every report rule except the code's own classification. Codes whose rows are all excluded anyway (by date, the AE/UCPath overlap, a missing or off-list 204 SFN, or an excluded department, account or purpose) are left out, so they no longer appear in Data Classification or block the stage. v_TransactionInclusion now exposes the chart-string columns the view reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SQL Server compares codes case-insensitively, so the candidates view can return a casing that differs from the seeded SegmentClassifications row. The in-memory match was exact, which dropped the code from the grid and let Data Classification complete with it still blank. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An unclassified fund has no derived SFN, which hid the department, account, purpose and activity codes on its rows. An excluded department on a blank fund then hid both codes, with neither reachable from the grid. Only a classification of no should hide other codes, so rows with an unclassified fund now pass the SFN gate. An excluded fund still has no SFN and still hides them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the work from #101 on main. #101 was merged into rpm/204-inclusion-rules 11 seconds after #100 had already merged that branch into main, so its commits never reached main.
Without it, Data Classification lists every code in SegmentClassifications and the stage stays blocked until all of them are classified. That is why the current import shows thousands of unclassified codes instead of about 20.
Commits, unchanged from #101:
The branch merges into current main with no conflicts.
Deploy note: the DACPAC must be published so v_ClassificationCandidates exists before the API is deployed.
🤖 Generated with Claude Code