Repository navigation
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a
netip.Addrornetip.AddrPorttoStringercan allocate even when the log level is disabled. Document usingLogger.Checkfollowed byStringto avoid boxing the address and to skip formatting dropped entries. Include an executable example and benchmarks for both types with logging enabled and disabled.Related to #1125. This is a documentation workaround using existing APIs, not native netip field support, and intentionally does not close the feature request. Enabled entries still allocate for string formatting and fields.
Allocation results on Go 1.24.2, darwin/arm64 (Apple M1 Pro), consistent across three runs:
Validation:
make test: passed across all four modules, with the race detector.go test -run '^ExampleLogger_Check' -bench '^BenchmarkNetipFields$' -benchmem -count=3 .: passed.make tidy-lint license-lint: passed.make golangci-lint: passed across all four modules using golangci-lint v2.14.0 and Go 1.26.9.GOTOOLCHAIN=go1.26.9 make vulncheck: passed.The initial
make lintattempt used a local golangci-lint built with Go 1.24, which could not load the Go 1.25 gRPC test module. The initial vulnerability scan also reported old Go 1.24.2 standard-library vulnerabilities. Both checks passed after selecting the newer tools; repository dependencies were unchanged.