Repository navigation
fix(zapgrpc): add WithVerbosity for correct grpclog V() semantics - #1597
Open
hardikkaurani wants to merge 1 commit into
Open
hardikkaurani wants to merge 1 commit into
hardikkaurani wants to merge 1 commit into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1544
Problem
In
grpclog.LoggerV2,V(l int) boolis documented to report whether verbosity levellis at or below the configured verbose logging threshold. However,zapgrpc.Logger.Vhistorically confused verbosity levels with zap's severity levels by mapping the verbosity int to a severity via_grpcToZapLevel[level]. This meant that verbose traces gated onV(l)were toggled purely based on the core's severity level instead of the intended verbosity level logic.Solution
This PR adds an opt-in
WithVerbosity(int)option that preserves backwards compatibility but allows callers to correctly switch to grpclog's documented verbosity semantics.When
WithVerbosity(verbosity)is provided during Logger construction:useVerbosityflag is toggled on.V(level)will evaluatelevel <= verbosityrather than looking up severity levels.If
WithVerbosityis not provided, the default behaviour is preserved andV(l)maps to zapcore severity, ensuring no disruption for current users.Testing
TestLoggerVthat verifies the fallback functionality.TestLoggerVWithVerbositythat verifies verbosity evaluations checklevel <= verbosityindependent of the underlying core severity level.