Repository navigation
Don't escape math on serialization - #115
Merged
Merged
Conversation
Drodt
requested changes
Aug 29, 2026
Drodt
left a comment
Drodt
left a comment
Collaborator
There was a problem hiding this comment.
A step in the right direction. Thank you! Just a minor change.
| /// The `is_verbatim` argument indicates whether this string is intended for | ||
| /// a verbatim field like `file` with limited escapes. | ||
| pub fn to_biblatex_string(&self, is_verbatim: bool) -> String { | ||
| if let Chunk::Math(s) = self { |
Collaborator
There was a problem hiding this comment.
Please add a reference to #76 here so the code is understandable.
Contributor
Author
There was a problem hiding this comment.
I added it to the new tests too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #76, it fixes the math serialization, but the spacing one is still wrong, I added ignored tests for that case, for accents and the math. The spacing stuff I saw it a bit complex as for what correct design to come up with for the solution, so I left it.