You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hola Annel,
Por favor corregir.
Igual que en anterior commit, después de esto :
And I fill in enter destination input with "Little Havana"
no se puede hacer ninguno de los pasos indicados sin haber seleccionado un resultado de la lista. Antes de "select a date" deberías "tap on result from the results list".
Hi Carlos.
La observacion es correcta.
La seleccion de la lista se la esta realizando en el .rb file que esta incluida en ese paso:
And(/^I fill in enter destination input with "(._)"$/) do |arg|
xpath("//android.widget.EditText[@resource-id="com.booking:id/disam_search"]").type "#{arg}"
sleep(3.seconds) _xpath("//android.widget.LinearLayout[@index="0"]").click*
end
Si ven conveniente podemos separar este, como otro paso.
De todos modos aclarar el feature subido de search.feature y su repectivo bookingSteps.rb file, los valide previamente, los mismos estan corriendo as Passed.
Creo que separarlo es mejor, será mas claro, y mas versátil, esto nos permitiría seleccionar otros resultados de la lista si es necesario:
And I type destination "Little Havana" in enter destination search field
And I open the first result from destination search
Cambiar la palabra "choice" (selección) por "choose" (seleccionar).
Renombrar el archivo "bookingSteps.rb" a "search.rb"
No veo los cambios solicitados en el anterior comentario, pero bueno, cuando haya que implementar se apreciara la necesidad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.