Kinetic Forge skin: sign-in + sign-up + onboarding from Stitch - #95
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97bffbdca7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| * IGNITE FORGE button goes to /app/chat. | ||
| */ | ||
| export default function OnboardingPage() { | ||
| const { isSignedIn, user, isLoaded } = useUser(); |
There was a problem hiding this comment.
Guard Clerk hook when auth is disabled
When NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY is unset or invalid, ClerkShell deliberately renders children without a ClerkProvider and the auth pages fall back to ClerkPlaceholder; this new onboarding page still calls useUser() unconditionally, so the no-Clerk/local/demo path will throw before the page renders. Please mirror the sign-in/sign-up guard or avoid Clerk hooks unless the provider is mounted.
Useful? React with 👍 / 👎.
| // Ocultar splash si aparece | ||
| body.style.background = "#0A0A0A"; | ||
| body.style.color = "#e5e2e1"; | ||
| body.classList.remove("scanlines"); |
There was a problem hiding this comment.
Restore body classes after auth routes
When a user leaves /sign-in via client-side navigation, this removes the root scanlines class from document.body but the cleanup only clears inline styles, so every subsequent page in the same session loses the global scanline styling until a full reload. Save and restore the previous body.className as the prior layout did.
Useful? React with 👍 / 👎.
| .ob-root{background:#0A0A0A;color:#e5e2e1;font-family:Inter,-apple-system,sans-serif;min-height:100vh} | ||
| .ob-root *{box-sizing:border-box} | ||
| .ob-mono{font-family:'JetBrains Mono',monospace} | ||
| .ob-hanken{font-family:'Hanken Grotesk',Inter,sans-serif} | ||
| .ob-plasma{color:#00F0FF} |
There was a problem hiding this comment.
Replace hard-coded skin colors with tokens
The repo AGENTS.md rule “Tokens, no hex” requires production colors to go through var(--...)/the token system, but this skin introduces raw hex and RGBA values directly in the onboarding/auth UI. That bypasses theme/token updates and violates the documented gate; please map these values to existing or newly-added tokens instead.
Useful? React with 👍 / 👎.
Reemplaza TODO el visual de auth y onboarding con el tema Kinetic Forge de los Stitch de Luis. Sign-in/up: fondo #0A0A0A, accent #00F0FF, grid-bg, corner-accents, Clerk styled. Onboarding: port directo del Stitch vforge_onboarding_inteligente con Clerk useUser real, OAuth buttons cableados a /api/auth/github|vercel/start, IGNITE FORGE va a /app/chat.