Retire the legacy obsidian theme default - #101
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f656b3826
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // VForge Studio tiene una sola base visual. Neutraliza preferencias de la | ||
| // etapa obsidian para que no reaparezcan en menús o rutas secundarias. | ||
| localStorage.removeItem("vforge.theme"); | ||
| setThemeState("light"); |
There was a problem hiding this comment.
When a route initially mounts the existing ThemeToggle (for example the legacy dashboard or onboarding), its mount effect initializes its private state to dark and applies that theme; this parent effect then forces the document and vf-theme back to light without updating the toggle's state (components/controls/ThemeToggle.tsx:10-15). The control therefore displays the dark-state icon/label while the page is light, and its first click computes light again and appears to do nothing. Reset or remove those controls together with this forced state, or make them consume the provider state.
Useful? React with 👍 / 👎.
1 participant
Elimina la preferencia oscura heredada que podía reaparecer desde
localStorage. VForge Studio arranca siempre desde la base clara y mantiene intacta la API de tema para componentes históricos.Validado con TypeScript, ESLint, 17/17 pruebas y build completo de Next.js.