Add/Remove Profile from Lists by joelmuraguri · Pull Request #1202 · tunjid/heron

joelmuraguri · 2026-04-12T21:00:33Z

What

Allows a signed-in user to add or remove any profile from their own lists directly from the profile screen, via a bottom sheet picker.

Changes

UI

Added a new entry in ProfileActionsMenu to trigger the list membership editor
Implemented ListMemberPickerBottomSheet shows the signed-in user's lists with a FilterChip per item indicating current membership status (Add/Remove)
ListMemberPickerItem uses RecordLayout with ListMembershipChip driven by a nullable ListMember? presence means member, null means not

Data

Added membershipsByProfile(profileId) DAO query on listMembers table scoped to a subject profile
Implemented membershipsByProfile in the repository using singleAuthorizedSessionFlow, returning Flow<List<ListMember>> for the viewed profile

ViewModel / State

Added profileListMemberships: List<ListMember> and signedInProfileListsHolder to State
loadProfileMutations now uses flatMapLatest to resolve profile.did before fetching memberships avoids unsafe ProfileHandleOrId cast
Added Action.AddListMember with a corresponding enqueueMutation writing FeedList.AddMember to the WriteQueue
Removal reuses the existing Action.DeleteRecord since ListMemberUri is a RecordUri

Why

The lists data was already loaded per profile tab via ProfileScreenStateHolders.Records.Lists the signed-in user's lists are sourced from a dedicated signedInProfileListsHolder so the correct lists always appear regardless of which profile is being viewed.

Demo

XRecorder_20260412_01.mp4

gemini-code-assist

Code Review

This pull request introduces the ability to manage profile memberships within lists, adding database queries, repository methods, and a bottom sheet for selection. The reviewer identified a logic bug in the view model where state initialization could be incorrectly skipped and highlighted a data isolation issue where memberships should be scoped to the signed-in user. Additional suggestions include refactoring redundant flow logic for better idiomatic Kotlin and moving hardcoded strings to resources for localization.

tunjid · 2026-04-13T13:57:34Z

+    companion object {
+        @Composable
+        fun rememberListMemberPickerSheetState(
+            paneTransitionScope: PaneTransitionScope,


Compose modal bottom sheets do not share the same window with the app, they are dialogs backed by a separate window and therefor a separate window token. Due to this dialogs cannot have shared elements with the rest of the app, making the paneTransitionScope have no effect.

tunjid · 2026-04-13T14:02:25Z

 }

+@Composable
+fun ListMemberPickerItem(


List members are profile oriented, so the ProfileWithViewerState Composable in the com.tunjid.heron.timeline.ui.profile package is more appropriate. If you go to the ListsScreen, the people tab has a layout for displaying list members. I think we should consolidate around this template.

Oh I see, this is for displaying lists that we may want edit memberships of.

tunjid · 2026-04-13T14:50:08Z

+    override fun membershipsByProfile(
+        profileId: ProfileId,
+    ): Flow<List<ListMember>> =
+        savedStateDataSource.singleAuthorizedSessionFlow { signedInProfileId ->


This just fetches from the db with no network refresh. If you open the bluesky website and inspect network traffic, when adding a profile to the lists of the signed in user, they make a call to the API to the signed in profiles list members records to fetch all the list members the signed in user has created.

This is the only way they are able to tell if a profile already exists in a list or not. Its inefficient, but what we have to do to.

There should also be a createdListMembers method, and should be exposed on RecordRepository via BlueskyRecordOperations. It should list the listRecords XRPC to paginate list members on the app.bsky.graph.listitem collection. Only then can we verify that a profile is a member of a list or not.

Okay I hear you and your approach makes sense, I have made changes regarding this.

joelmuraguri · 2026-04-14T12:53:15Z

/gemini review

gemini-code-assist

Code Review

This pull request implements the functionality to manage profile memberships within user-created lists. Key changes include the addition of listMembersByProfile to the repository and DAO layers, the introduction of a ListMemberPickerSheetState for a new bottom sheet UI, and the integration of "Add to List" actions within the profile screen. Review feedback identifies a critical logic error in OfflineFirstRecordRepository where the signed-in user's ID is incorrectly used instead of the viewed profile's ID for membership queries. Additionally, it is noted that the current synchronization logic only fetches the first page of list items, which may lead to incomplete membership data, and a suggestion was made to use existing constants for collection names to improve maintainability.

gemini-code-assist · 2026-04-14T12:55:43Z

+                    createdListMembers(
+                        query = CreatedListMembersQuery(
+                            profileId = signedInProfileId,
+                            data = CursorQuery.Data(
+                                page = 0,
+                                cursorAnchor = Clock.System.now(),
+                                limit = 15,
+                            ),
+                        ),
+                        cursor = Cursor.Initial,
+                    ).first()


Calling .first() on the flow returned by createdListMembers only syncs the first page of list items (currently limited to 15). If the viewed profile is a member of a list but that membership record isn't in the first 15 records of the user's app.bsky.graph.listitem collection, it won't be detected. Consider increasing the limit or ensuring all pages are synced to provide accurate membership status.

This is valid.

tunjid · 2026-04-14T16:53:17Z

+        savedStateDataSource.singleAuthorizedSessionFlow { signedInProfileId ->
+            combine(
+                listDao.listMembersByProfile(
+                    profileId = query.profileId.id,


The pagination here will likely break as this db query does not match the network result. The DB query should fetch list members created by the signed in profile, it shouldn't need a profile Id.

tunjid · 2026-04-14T16:55:09Z

+    listItem: Listitem,
+) {
+    add(
+        ListMemberEntity(


Trying to save a list member without saving the profiles of the list members will cause errors because of failed foreign key constraints.

tunjid

Think a little big picture about this. You want to add or remove a profile from the signed in profiles lists. To do this reliably, you want to present to the signed in user if a profile is in their lists.

What are the things you need to know to present this?
Do you have a reliable way of getting this information?

…adProfileMutations

…ign-in and account switching

…lists table

…r localization

…ByProfile for filtered read

…ry with network result

joelmuraguri requested a review from tunjid April 12, 2026 21:00

gemini-code-assist Bot reviewed Apr 12, 2026

View reviewed changes

tunjid reviewed Apr 13, 2026

View reviewed changes

joelmuraguri force-pushed the joel/allow-adding-profile-in-list-ui branch from b41ca46 to ae9ee04 Compare April 14, 2026 12:44

gemini-code-assist Bot reviewed Apr 14, 2026

View reviewed changes

tunjid reviewed Apr 14, 2026

View reviewed changes

joelmuraguri added 19 commits April 16, 2026 16:37

add edit list membership option to profile actions menu

8747445

add membershipsByProfile DAO query and repository implementation

dae715e

add signedInProfileListsHolder and profileListMemberships to State

e3a50ee

wire list membership and signedInProfileListsHolder mutations into lo…

cff41f4

…adProfileMutations

implement ListMemberPickerBottomSheet with add/remove chip

0130681

initialize signedInProfileListsHolder before early return to handle s…

e0e9dae

…ign-in and account switching

scope membershipsByProfile query to signed-in user lists via JOIN on …

fce5119

…lists table

extract bottom sheet title and list subtitle into string resources fo…

462fd46

…r localization

fetch list members from API to verify profile membership

5581fdb

remove paneTransitionScope from ListMemberPickerSheet

789501a

fixes

f577b7a

cache profile uri to satisfy foreign key constraints

b8c1df5

split query into listMembersCreatedByProfile for sync and listMembers…

ca36956

…ByProfile for filtered read

use listMembersCreatedByProfile in createdListMembers to align DB que…

349dff7

…ry with network result

implement a writable for listRecords

c0044ca

implement a writable for listRecords

5af3d7b

remove sync query,it was unnecessary

88533e0

update state to use a map for ui logic check if profile is ListMember

3e19663

update sheetState to start sync for listRecords and dismiss flow

55efd07

joelmuraguri force-pushed the joel/allow-adding-profile-in-list-ui branch from 913e3bd to 55efd07 Compare April 16, 2026 13:54

Conversation

joelmuraguri commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Changes

UI

Data

ViewModel / State

Why

Demo

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joelmuraguri commented Apr 14, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist Bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tunjid left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joelmuraguri commented Apr 12, 2026 •

edited

Loading