feat(site): restyle inner pages to the editorial drafted-sheet identity - #104
Conversation
Unify guide, gallery, and start with the project page's visual world: warm paper, Fraunces display type, international-orange accent, mono labels, and dark only where the product itself is dark (command blocks and live artifact plates). All page logic, i18n, and build pipelines are unchanged; templates were rewritten and pages rebuilt. - start: editorial lead, ink tab states, dark command plates - guide: editorial hero, paper chooser/result cards, print-depth type hues - gallery: editorial hero and proof cards on paper, type-hue accents derived from the shared TYPE_ACCENTS map in build-gallery.mjs - shared fixed nav across all four pages (Guide / Proof Lab / Start / GitHub / language / Install Skill) with aria-current markers - index: nav 'Docs' anchor renamed to a real Start link, Gallery label aligned to Proof Lab, closing CTA section, mini-node palette strip, equal-height quickstart cards, tighter section rhythm
- gallery: restore the 44px touch-target contract on nav-logo, filter-button, and card-link; update the gallery test's brand hook to the renamed .nav-logo selector - guide: restore the footer CLI hint 'archify guide "your scenario"' asserted by the guide page contract test
Visual review — the Diagram Types deck mixes themes without a semantic ruleThe dark/light alternation in the Diagram Types section currently feels accidental rather than intentional. What I see:
Because these cards represent five peer diagram types, their theme should not imply importance or state. At the moment, luminance is creating an unintended hierarchy:
This is different from the dark plate in the hero. The hero treatment works because darkness has a clear semantic role there: it is the live product artifact, mounted inside the editorial paper frame. The dark specimen card also communicates a selected state. In the Diagram Types deck, however, dark and light do not correspond to selection, interaction, category, or any other visible rule. I checked the implementation and this appears to come from the source captures themselves:
So this is not a CSS striping effect; the preview assets were captured using inconsistent themes. These assets were already present before this PR, but the mismatch becomes much more noticeable now that the rest of the site is being unified around the warm-paper editorial identity. Recommended directionMy preferred solution is to normalize all five previews to the light theme in this section. That would:
A consistent all-dark preview treatment could also work, provided every card uses the same preview framing, crop, and light description surface. The important point is that theme should be controlled at the section level rather than chosen independently for each screenshot. If demonstrating dual-theme support is the intent, that should be made explicit through either:
Alternating themes case by case does not clearly communicate dual-theme capability. Acceptance criteriaBefore considering the section visually resolved, I would expect:
Could we normalize these preview assets as part of this visual-unification pass? |
…rule The Diagram Types deck mixed dark and light source captures with no semantic rule, letting the largest Architecture card dominate through luminance. Recapture all five previews in the light theme with one framing spec (1440px viewport, 2x scale, diagram-plate crop, floating viewer chrome hidden) so the five peer types read as one family and dark surfaces stay reserved for live product plates and selected states. Architecture moves to a dedicated archify-architecture.png so archify-dark.png keeps its role in the README dark/light pair.
|
Thanks for the detailed read — agreed on all counts, and this is now addressed in 1c0e403. What changed
Against the acceptance criteria
One local note: |
The release-identity gate requires a prerelease version whenever CHANGELOG Unreleased carries entries; this site-only PR stays on the stable identity like its earlier commits.
YunyueLi
left a comment
There was a problem hiding this comment.
Approved — the visual direction is now coherent and merge-ready. The five diagram-type previews follow one light capture rule, so the section no longer creates an accidental hierarchy between dark and light artifacts.
I rechecked the remaining polish notes: the featured Architecture crop at the current card ratio, the Install Skill CTA clipping at 320px, and the small cyan Architecture kicker contrast. These are real but minor and non-blocking; none should hold up this PR, and they can be handled as follow-up polish.
All current CI checks pass. From a visual/UI review perspective, this is good to merge.
Summary
The three inner pages (
guide.html,gallery.html,start.html) used a midnight-console visual world while the project page uses the warm-paper editorial one — clicking through felt like leaving the site. This PR rewrites the three templates (scripts/guide-template.html,gallery-template.html,start-template.html) into the index page's drafted-sheet identity and rebuilds the generated pages.aria-currenton the active page. Index nav: theDocslabel (an in-page anchor) is now a real Start link, andGalleryis labeled Proof Lab to match the page's own name.build-gallery.mjsnow derive from a shared print-depthTYPE_ACCENTSmap (same hues the guide uses).Test plan
node scripts/build-start.mjs && build-guide.mjs && build-gallery.mjs— all rebuild cleannode scripts/check-release-identity.mjs—release identity ok: 2.15.0Note: a local full
run-tests.mjsrun shows one failure inreal-repository-proof.test.mjsthat is pre-existing and environment-dependent — it only runs its strict comparison when a siblingmcoclone exists, and it fails identically on cleanorigin/mainwith that clone present. Unrelated to this diff.Review focus: template rewrites are large but mechanical (style + chrome only); the meaningful review surface is visual — open the four built pages under
docs/.