Repository navigation
🚨 unwelcome pr from bot 🚨 - #117
Closed
woahwhattheheck wants to merge 1 commit into
Closed
woahwhattheheck wants to merge 1 commit into
woahwhattheheck wants to merge 1 commit into
Conversation
|
We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:
Please review these AI-assisted contribution guidelines and update this contribution if needed. We're closing this for now as the account looks automated. If we got that wrong, please just reopen the PR and we'll take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48.
When the workspace is on
P:and trace storage is onC:, the trace command currently embeds a POSIXcdexpression and starts the child in extension storage. Run the compiler directly withspawn'scwdset to the workspace for command-palette tracing or the selected source directory for explorer tracing.The helper quotes the trace output path for the Windows default shell or POSIX shell, escapes POSIX apostrophes, and uses a replacement callback to preserve literal dollar sequences in path names. Windows uses the platform default shell; POSIX retains
SHELLwhen configured, with a default-shell fallback.Related: #52, #54, #77. This change also fixes the command-palette working directory: their current patches retain
newDirName ?? projectPath.value, whereprojectPathis extension storage. This usesdirectory ?? workspacePathand covers that distinction.Validation on Linux with Node 24.19.0:
pnpm exec vitest run: 2 files / 5 tests passed, including 4 trace-invocation cases for Windows palette/explorer paths and POSIX quoting.pnpm lint,pnpm typecheck, andpnpm buildpassed.$&.git diff --checkpassed.Native Windows execution and the hosted CI matrix have not been run locally; the Windows cases above exercise invocation construction.