Skip to content

🚨 unwelcome pr from bot 🚨 - #117

Closed
woahwhattheheck wants to merge 1 commit into
tsperf:mainfrom
woahwhattheheck:fix/tracer-48-cross-drive-20261005
Closed

woahwhattheheck wants to merge 1 commit into
tsperf:mainfrom
woahwhattheheck:fix/tracer-48-cross-drive-20261005

Conversation

@woahwhattheheck

Copy link
Copy Markdown

Fixes #48.

When the workspace is on P: and trace storage is on C:, the trace command currently embeds a POSIX cd expression and starts the child in extension storage. Run the compiler directly with spawn's cwd set to the workspace for command-palette tracing or the selected source directory for explorer tracing.

The helper quotes the trace output path for the Windows default shell or POSIX shell, escapes POSIX apostrophes, and uses a replacement callback to preserve literal dollar sequences in path names. Windows uses the platform default shell; POSIX retains SHELL when configured, with a default-shell fallback.

Related: #52, #54, #77. This change also fixes the command-palette working directory: their current patches retain newDirName ?? projectPath.value, where projectPath is extension storage. This uses directory ?? workspacePath and covers that distinction.

Validation on Linux with Node 24.19.0:

  • pnpm exec vitest run: 2 files / 5 tests passed, including 4 trace-invocation cases for Windows palette/explorer paths and POSIX quoting.
  • pnpm lint, pnpm typecheck, and pnpm build passed.
  • A real POSIX child process confirmed the source working directory and literal trace path containing spaces, an apostrophe, and $&.
  • git diff --check passed.

Native Windows execution and the hosted CI matrix have not been run locally; the Windows cases above exercise invocation construction.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:

  1. Never let an LLM speak for you - all comments, issues, and PR descriptions should be written in your own words, reflecting your own understanding.
  2. Never let an LLM think for you - only submit contributions you fully understand and can explain.

Please review these AI-assisted contribution guidelines and update this contribution if needed.

We're closing this for now as the account looks automated. If we got that wrong, please just reopen the PR and we'll take another look.

@github-actions github-actions Bot changed the title fix: trace from workspace cwd across Windows drives 🚨 unwelcome pr from bot 🚨 Oct 5, 2026
@github-actions github-actions Bot closed this Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trace doesn't work if project isn't on C:/ drive

1 participant