Skip to content

trunk-merge/pr-1164/d8b1712e-554d-45be-acfc-ab7f46098378 #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trunk-io wants to merge 3 commits into from
Closed

trunk-merge/pr-1164/d8b1712e-554d-45be-acfc-ab7f46098378 #1168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
539e8e8
linters(dart): parse the JSON analyze output and batch from the proje…
AndrewDongminYoo Aug 29, 2026
e92beb3
linters(dart): regenerate the analyze snapshot for JSON messages
AndrewDongminYoo Aug 29, 2026
7c2087f
Merging e92beb34a2d0be59f17e4645b4e71fe83e100552 into trunk-temp/pr-1…
trunk-io[bot] Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions linters/dart/plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ lint:

- name: analyze
output: regex
# The output only includes the filename so in order to use a relative path we need to run from parent.
run_from: ${parent}
parse_regex:
\s*(?P<severity>.*) - (?P<path>.*):(?P<line>\d+):(?P<col>\d+) - (?P<message>.*) -
(?P<code>.*)
run: dart analyze --no-fatal-warnings ${target}
# The JSON format reports absolute paths, so a batch can be analyzed in a single pass from
# the project root rather than once per parent directory. The default format is explicitly
# documented as unstable between releases.
run_from: ${root_or_parent_with(analysis_options.yaml)}
parse_regex: '"code":"(?P<code>[^"]+)","severity":"(?P<severity>[A-Z]+)","type":"[A-Z_]+","location":\{"file":"(?P<path>[^"]+)","range":\{"start":\{"offset":\d+,"line":(?P<line>\d+),"column":(?P<col>\d+)\}.*?"problemMessage":"(?P<message>[^"]*)"'
run: dart analyze --no-fatal-warnings --format=json ${target}
success_codes: [0, 3]
batch: true
8 changes: 4 additions & 4 deletions linters/dart/test_data/dart_v3.9.2_basic.check.shot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ exports[`Testing linter dart test basic 1`] = `
"level": "LEVEL_LOW",
"line": "12",
"linter": "dart",
"message": "Parameters ''x' and 'y'' could be super parameters. Trying converting ''x' and 'y'' to super parameters.",
"message": "Parameters ''x' and 'y'' could be super parameters.",
"targetType": "dart",
},
{
Expand All @@ -24,7 +24,7 @@ exports[`Testing linter dart test basic 1`] = `
"level": "LEVEL_HIGH",
"line": "16",
"linter": "dart",
"message": "Undefined name 'find'. Try correcting the name to one that is defined, or defining the name.",
"message": "Undefined name 'find'.",
"targetType": "dart",
},
{
Expand All @@ -36,7 +36,7 @@ exports[`Testing linter dart test basic 1`] = `
"level": "LEVEL_HIGH",
"line": "16",
"linter": "dart",
"message": "Undefined name 'empty'. Try correcting the name to one that is defined, or defining the name.",
"message": "Undefined name 'empty'.",
"targetType": "dart",
},
{
Expand All @@ -48,7 +48,7 @@ exports[`Testing linter dart test basic 1`] = `
"level": "LEVEL_HIGH",
"line": "16",
"linter": "dart",
"message": "The function 'expect' isn't defined. Try importing the library that defines 'expect', correcting the name to the name of an existing function, or defining a function named 'expect'.",
"message": "The function 'expect' isn't defined.",
"targetType": "dart",
},
],
Expand Down
Loading