Repository navigation
Update cli output descriptions - #810
Merged
Merged
Conversation
|
😎 Merged successfully - details. |
gnalh
force-pushed
the
gabe/trunk-16938-update-cli-descriptions
branch
from
November 5, 2025 00:21
35d9641 to
c889cab
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #810 +/- ##
==========================================
+ Coverage 72.79% 73.03% +0.24%
==========================================
Files 72 72
Lines 15960 15960
==========================================
+ Hits 11618 11657 +39
+ Misses 4342 4303 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cmillar-trunk
approved these changes
Nov 5, 2025
| value_delimiter = ',', | ||
| value_parser = clap::builder::NonEmptyStringValueParser::new(), | ||
| help = "Comma-separated list of glob paths to junit files." | ||
| help = "Comma-separated list of glob patterns to locate JUnit XML files (e.g., '**/test-results/**/*.xml')." |
Contributor
There was a problem hiding this comment.
Nit: do patterns have to be quoted when we pass them?
Contributor
Author
There was a problem hiding this comment.
They can be, but we don't require it -- except on mac when using globs. I added the quotes for emphasis, but can remove if needed. I think they are better left in though.
| value_delimiter = ',', | ||
| value_parser = clap::builder::NonEmptyStringValueParser::new(), | ||
| help = "Comma-separated list of glob paths to test report files." | ||
| help = "Comma-separated list of glob patterns to test report files. Supports JUnit XML, Bazel BEP, and XCResult formats." |
riya-n
approved these changes
Nov 5, 2025
mb1206
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.