Repository navigation
[variant] Add missing variant in ID generation - #809
trunk-io[bot] merged 3 commits into
Conversation
|
😎 Merged successfully - details. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
==========================================
+ Coverage 72.79% 73.10% +0.31%
==========================================
Files 72 72
Lines 15960 16024 +64
==========================================
+ Hits 11618 11715 +97
+ Misses 4342 4309 -33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| }); | ||
| } | ||
| } else { | ||
| gen_info_id( |
There was a problem hiding this comment.
We have a generate_info_id_variant_wrapper in the same file as gen_info_id that should encapsulate this logic.
mb1206
left a comment
There was a problem hiding this comment.
seems good to me! this would be something that would only affect new tests right? or would it regenerate ids for existing tests?
These are the same IDs that are already being used in the ETL, we just haven't flipped the switch yet to use these internal.bin files yet. |
8918951 to
9b91704
Compare
Also address xcresult not supporting variants